Improved zend string api (2) #1381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing methods
Does not change anything to the generated code (thanks to compat macros) but cleaner.
Add compatibility macros to allow using previous names
Add compatibility macro. Function should probably be moved for zend_operators.c to zend_string.c.
Also remove some macros we can define later when migrating the existing code to the new API.
|
Yes, we could add a '_P' suffix to be consistent with Z_ADDREF_P. But the original function name is zend_string_addref() and we already have ZSTR_VAL(), ZSTR_LEN(), and ZSTR_HASH(). So, I prefer leaving the choice to Dmitry. Dmitry suggested we changed every zend_string_xxx() function name to use 'ZSTR_' prefixes. So, even if zend_string_tolower() is not declared in zend_string.h, it is renamed. And the new name is not Z_STRTOLOWER, it is ZSTR_TOLOWER. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1367 (prematurate close).