Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1 #13922

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1 #13922

merged 1 commit into from
Jun 24, 2024

Conversation

arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Apr 9, 2024 •
edited
Loading

sysconf() can return -1 for _SC_GETPW_R_SIZE_MAX and related configuration. This is allowed by posix and is not necessarily an error. In particular, musl always returns -1.

This is a followup of #13921

@arnaud-lb arnaud-lb requested a review from devnexen April 9, 2024 13:59
This was referenced Apr 9, 2024
Open
Merged
devnexen
devnexen approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. That might not only solve musl but also an old FreeBSD issue if I recall well.

@arnaud-lb arnaud-lb mentioned this pull request Apr 9, 2024
Draft
@arnaud-lb
Copy link
Member Author

Closing this one in favor of #13876

@arnaud-lb arnaud-lb closed this Apr 11, 2024
@arnaud-lb arnaud-lb reopened this Jun 11, 2024
@arnaud-lb
Copy link
Member Author

Reopening because #13876 has stalled.

@arnaud-lb arnaud-lb marked this pull request as ready for review June 11, 2024 17:49
@arnaud-lb arnaud-lb requested a review from bukka as a code owner June 11, 2024 17:49
@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.2 June 12, 2024 12:38
@arnaud-lb
Copy link
Member Author

Changed the target branch to PHP-8.2, like #13921. I will merge if there is a new approval, since this was only approved for master.

@arnaud-lb
Copy link
Member Author

@devnexen @bukka do you approve merging this in 8.2 ?

@devnexen
Copy link
Member

Yes. At first glance it looks like feature improvement, but it s a fix as for me.

@arnaud-lb arnaud-lb merged commit 3fbca7f into php:PHP-8.2 Jun 24, 2024
9 checks passed
arnaud-lb added a commit that referenced this pull request Jun 24, 2024
@arnaud-lb
[ci skip] NEWS for GH-13922
d7ef2c2
arnaud-lb added a commit that referenced this pull request Jun 24, 2024
@arnaud-lb
Merge branch 'PHP-8.2' into PHP-8.3
b1119de 
* PHP-8.2:
  [ci skip] NEWS for GH-13922
  Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1 (#13922)
arnaud-lb added a commit that referenced this pull request Jun 24, 2024
@arnaud-lb
[ci skip] NEWS for GH-13922
e230610
arnaud-lb added a commit that referenced this pull request Jun 24, 2024
@arnaud-lb
Merge branch 'PHP-8.3'
ff58a7f 
* PHP-8.3:
  [ci skip] NEWS for GH-13922
  [ci skip] NEWS for GH-13922
  Support sysconf(_SC_GETPW_R_SIZE_MAX) == -1 (#13922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard OS: Alpine / Musl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnaud-lb @devnexen