Alpine CI #13925

arnaud-lb · 2024-04-09T14:17:57Z

This adds an Alpine job to the push workflow.

The "Alpine CI" commit is based on #8621 (I will add @mvorisek as co-author).

I will open separate PRs for other changes:

Most changes are not musl-specific and benefit other platforms.

The musl iconv implementation's behavior differs considerably from the glibc one. Currently the iconv tests rely on the glibc behavior, and it is required to build the extension against the gnu-libiconv package. This solves discrependices in the iconv extension, but unfortunately some libraries use musl iconv, at least on Alpine. For instance libxml does, and this affects the library's ability to handle some charsets.

The icu-data-full package is also required because Alpine stripes locale data from the ICU package.

I believe that the hunspell-en and enchant2-hunspell packages also helped to make the enchant test suite pass.

Zend/zend.c

.github/actions/configure-alpine/action.yml

.github/actions/test-alpine/action.yml

iluuu1994 · 2024-06-25T13:52:49Z

.github/workflows/push.yml

+            asan: false
+          - debug: true
+            zts: true
+            asan: true


I would suggest just the latter, two builds seem like overkill to me. Instead, you could add both to nightly.

Honestly, I wonder if it wouldn't be more useful to just move this to nightly but with all extensions enabled. WDYT? Or do you think this tests something unique (apart from alpine/musl)?

Honestly, I wonder if it wouldn't be more useful to just move this to nightly but with all extensions enabled. WDYT? Or do you think this tests something unique (apart from alpine/musl)?

I planned to also add a nightly job after this, but I don't mind moving this to nightly initially.

I won't object to either, but IMO the push itself is not a big value-add if it's unlikely to break, without the other builds breaking.

I've moved the job to nightly (tested in https://github.com/arnaud-lb/php-src/actions/runs/10388373807/job/28763941967). For now I didn't enable all extensions, but I may do later (in a separate change).

This is not redundant. Have you seen the OpenSSL issue list: #14036 ? This already shows that there are significant enough differences. Catching issues after the merge usually takes time and it is also riskier for releases.

As I mentioned those are low resource jobs so the load on planet is minimal (you should really see what normally runs in enterprise pipelines where usually you don't see any nightly runs and lots of jobs are high resource ones - everything is often done on push).

The way how I see it is to have only long running and pipelines with not enough credits to be run in nightly. Anywya we don't probably agree on this so I will leave decision to you as you are the code owner for this part. Feel free to remove the push then.

As mentioned, I don't inherently object to increasing CI time, but I do think we should keep it minimal, rather than keep growing it until it becomes a problem. I don't know what the OpenSSL issue is about, but since this change wasn't even caused by us, it wouldn't have prevented the failing of release branches either.

Anyway, this discussion has already gone on too long to be useful. I'll leave it up to Arnaud to decide whether to keep push or remove it.

@arnaud-lb I understand @iluuu1994 as any added CI pipeline increases the CI time meaning not only more energy used but also CI might delay other CIs for different PRs.

However I understand @bukka as well. Push CI pipelines are great for evaluating if PR or any commit is working properly.

I was neutral on this because of these pros and cons, but in past I strugled with #13771 many times and as reported there, many times this was left unnoticed for a while on master branch.

Based on this, I would support having Alpine tested on push with #13771, ie. one push job where the extensions would be build separately testing if the header files and dependencies of each extension are defined properly on push.

I've decided to merge only the nightly job for now. I will add a push job if nightly fails regularly.

@mvorisek I think what you suggest in #13771 would solve your issue as it would detect issues less than 24 hours after they were introduced?

#13771 about every second month the build was broken, so I would say it should be tested on push as it is not only an Alpine issue, but a build issue in general. But I am not the one who decide if it should be for nightly only or not.

And thank you for partnering in this PR and taking it to the finish line ❤🎉

mvorisek · 2024-07-23T10:24:01Z

 =====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
XMLWriter::toStream() with encoding - test GBK [ext/xmlwriter/tests/xmlwriter_toStream_encoding_gbk.phpt]
=====================================================================

This test is failing on Alpine as GBK encoding is probably not present, can some extra Alpine dependency fix it or should it be skipped on Alpine?

Then is there anything else remaining in order to merge this PR?

arnaud-lb · 2024-07-23T11:44:18Z

Yes I believe this is the last blocker. I'm trying to fix this test in #15072 :)

bukka · 2024-07-29T18:54:40Z

@arnaud-lb I guess all prereqs are merged, right? Would be good to get review from @iluuu1994 or @TimWolla . From the quick look, it looks good to me but will leave to code owners to do a proper review. It will be really great to have Alpine CI...

arnaud-lb · 2024-07-29T20:17:51Z

@bukka yes all prereqs are merged and the build is stable. Reviews welcome :)

TimWolla

Some remarks regarding the GitHub Action usage. Can't comment on the build steps themselves, because I have opinions about supporting Musl in the first place :-)

TimWolla · 2024-07-29T21:05:05Z

.github/actions/test-alpine/action.yml

+  testArtifacts:
+    default: null
+    required: false


TimWolla · 2024-07-29T21:05:12Z

.github/workflows/push.yml

+      - name: Test Tracing JIT
+        uses: ./.github/actions/test-alpine
+        with:
+          testArtifacts: ${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}${{ matrix.asan && '_ASAN' || '' }}_Tracing JIT


TimWolla · 2024-07-29T21:05:46Z

.github/actions/configure-alpine/action.yml

+          --enable-fpm \
+          --with-pdo-mysql=mysqlnd \
+          --with-mysqli=mysqlnd \
+          ${{ inputs.skipSlow == 'false' && '--with-pgsql' || '' }} \


There is no input called skipSlow.

arnaud-lb · 2024-08-12T19:48:12Z

I will merge this week unless there are objections

iluuu1994

LGTM otherwise

.github/actions/apk/action.yml

iluuu1994 · 2024-08-13T14:28:23Z

.github/actions/test-alpine/action.yml

+        sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \
+          -d opcache.jit=${{ inputs.jitType }} \
+          -d opcache.jit_buffer_size=64M \
+          -j$(($(nproc) - 1)) \


You can probably do -j$(nproc). The -1 was used as an attempt to fix crashes specific to macOS.

iluuu1994 · 2024-08-13T14:30:08Z

.github/workflows/push.yml

+            asan: false
+          - debug: true
+            zts: true
+            asan: true


Honestly, I wonder if it wouldn't be more useful to just move this to nightly but with all extensions enabled. WDYT? Or do you think this tests something unique (apart from alpine/musl)?

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

This reverts commit f309b05.

arnaud-lb added the OS: Alpine / Musl label Apr 9, 2024

github-actions bot added Category: Engine Extension: intl Extension: opcache Extension: posix Extension: standard labels Apr 9, 2024

dkarlovi mentioned this pull request Apr 22, 2024

Optional GNU C Library support crazywhalecc/static-php-cli#376

Closed

arnaud-lb mentioned this pull request May 21, 2024

fix group/passwd api misuse if ZTS #13876

Draft

arnaud-lb force-pushed the alpine-ci branch 2 times, most recently from 1bd310e to 79c9204 Compare June 24, 2024 18:10

arnaud-lb commented Jun 25, 2024

View reviewed changes

Zend/zend.c Show resolved Hide resolved

arnaud-lb changed the title ~~[wip] Alpine CI~~ Alpine CI Jun 25, 2024

arnaud-lb marked this pull request as ready for review June 25, 2024 13:29

arnaud-lb requested review from dstogov, iluuu1994 and TimWolla as code owners June 25, 2024 13:29

iluuu1994 reviewed Jun 25, 2024

View reviewed changes

arnaud-lb mentioned this pull request Jul 3, 2024

Fix test race condition #14790

Closed

arnaud-lb force-pushed the alpine-ci branch 2 times, most recently from 93987b0 to 197fb39 Compare July 9, 2024 13:27

arnaud-lb force-pushed the alpine-ci branch from 197fb39 to 2de98ab Compare July 22, 2024 17:44

arnaud-lb force-pushed the alpine-ci branch from 2de98ab to 16631fd Compare July 23, 2024 14:07

arnaud-lb requested a review from iluuu1994 July 23, 2024 14:53

TimWolla reviewed Jul 29, 2024

View reviewed changes

iluuu1994 approved these changes Aug 13, 2024

View reviewed changes

arnaud-lb force-pushed the alpine-ci branch from 0ac614b to 3ec9f2b Compare August 14, 2024 14:11

arnaud-lb and others added 7 commits August 28, 2024 16:47

Alpine/Musl CI

9750f5b

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>

Review

6c89145

Nightly

ee6895c

Remove redundancy

182b5f2

Add slack notif

7dc88da

Re-add push job

f309b05

Revert "Re-add push job"

b28ef38

This reverts commit f309b05.

arnaud-lb force-pushed the alpine-ci branch from dd4a20d to b28ef38 Compare August 28, 2024 14:48

arnaud-lb merged commit 5b482b7 into php:master Aug 28, 2024
9 of 10 checks passed

arnaud-lb mentioned this pull request Aug 28, 2024

[Chore] Officially support musl the same way glibc is supported #13877

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alpine CI #13925

Alpine CI #13925

arnaud-lb commented Apr 9, 2024 •

edited

Loading

iluuu1994 Jun 25, 2024

iluuu1994 Aug 13, 2024

arnaud-lb Aug 13, 2024

iluuu1994 Aug 13, 2024

arnaud-lb Aug 14, 2024 •

edited

Loading

bukka Aug 16, 2024

iluuu1994 Aug 18, 2024

mvorisek Aug 22, 2024

arnaud-lb Aug 28, 2024

mvorisek Aug 28, 2024 •

edited

Loading

mvorisek commented Jul 23, 2024

arnaud-lb commented Jul 23, 2024

bukka commented Jul 29, 2024

arnaud-lb commented Jul 29, 2024

TimWolla left a comment

TimWolla Jul 29, 2024

TimWolla Jul 29, 2024

TimWolla Jul 29, 2024

arnaud-lb commented Aug 12, 2024

iluuu1994 left a comment

iluuu1994 Aug 13, 2024

iluuu1994 Aug 13, 2024

Alpine CI #13925

Alpine CI #13925

Conversation

arnaud-lb commented Apr 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arnaud-lb Aug 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mvorisek Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

mvorisek commented Jul 23, 2024

arnaud-lb commented Jul 23, 2024

bukka commented Jul 29, 2024

arnaud-lb commented Jul 29, 2024

TimWolla left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arnaud-lb commented Aug 12, 2024

iluuu1994 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arnaud-lb commented Apr 9, 2024 •

edited

Loading

arnaud-lb Aug 14, 2024 •

edited

Loading

mvorisek Aug 28, 2024 •

edited

Loading