Skip to content

Add myself to ext-dom credits #14718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2024
Merged

Add myself to ext-dom credits #14718

merged 1 commit into from
Jun 29, 2024

Conversation

nielsdos
Copy link
Member

Suggested here [1] as well.

[1] #13819 (review)

@nielsdos nielsdos requested a review from bukka as a code owner June 29, 2024 13:18
@nielsdos
Add myself to ext-dom credits
a011b62 
Suggested here [1] as well.

[1] php#13819 (review)
Girgias
Girgias approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, considering the major rewriting :)

@Girgias Girgias merged commit 4a9ff0f into php:master Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: dom Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias