Skip to content

[part of RFC] DOM CSS selector support: querySelector(All), matches, closest #13819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2024

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Mar 27, 2024

Part of a larger RFC: https://wiki.php.net/rfc/dom_additions_84
This implements: querySelector, querySelectorAll, matches, closest, i.e. the 4 CSS selector methods.

The largest part of this PR is reimporting the CSS component of Lexbor, which I left out on purpose in the HTML 5 PR because we did not need it at that time.

@TimWolla
Copy link
Member

Updating Lexbor (which had file permission changes from 755 -> 644 so almost all files are touched).

Would it make sense to commit this already? Being a regular update it should be a simple PR and it would make this one likely much smaller.

@nielsdos
Copy link
Member Author

Updating Lexbor (which had file permission changes from 755 -> 644 so almost all files are touched).

Would it make sense to commit this already? Being a regular update it should be a simple PR and it would make this one likely much smaller.

In number of files changed this would indeed be a drastic decrease (and hopefully prevent GitHub's UI from breaking again). In terms of number of additions the CSS component reimport is the primary source.
I'll PR the Lexbor update separately, and leave the CSS component in here for now. I'll do that later this week.

@nielsdos nielsdos force-pushed the css-selectors branch 2 times, most recently from e877e12 to bc8d416 Compare April 27, 2024 21:35
@nielsdos nielsdos changed the title [part of RFC soon] DOM CSS selector support: querySelector(All), matches, closest [RFC] DOM CSS selector support: querySelector(All), matches, closest Jun 10, 2024
@nielsdos nielsdos changed the title [RFC] DOM CSS selector support: querySelector(All), matches, closest [part of RFC] DOM CSS selector support: querySelector(All), matches, closest Jun 10, 2024
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add your name to ext/dom/CREDITS 😜

nielsdos added a commit to nielsdos/php-src that referenced this pull request Jun 29, 2024
Suggested here [1] as well.

[1] php#13819 (review)
Girgias pushed a commit that referenced this pull request Jun 29, 2024
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have the most detailled look, but I can't see anything that stands out as weird

@nielsdos nielsdos merged commit 88da914 into php:master Jun 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants