-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[part of RFC] DOM CSS selector support: querySelector(All), matches, closest #13819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would it make sense to commit this already? Being a regular update it should be a simple PR and it would make this one likely much smaller. |
In number of files changed this would indeed be a drastic decrease (and hopefully prevent GitHub's UI from breaking again). In terms of number of additions the CSS component reimport is the primary source. |
e877e12
to
bc8d416
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to add your name to ext/dom/CREDITS 😜
Suggested here [1] as well. [1] php#13819 (review)
Suggested here [1] as well. [1] #13819 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have the most detailled look, but I can't see anything that stands out as weird
Part of a larger RFC: https://wiki.php.net/rfc/dom_additions_84
This implements: querySelector, querySelectorAll, matches, closest, i.e. the 4 CSS selector methods.
The largest part of this PR is reimporting the CSS component of Lexbor, which I left out on purpose in the HTML 5 PR because we did not need it at that time.