PHP 8.4 | Exit as function: fix incorrect parameter name #15433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/fix-up-13483-exit-as-function-param-name
branch
2 times, most recently
from
a3e58fd
to
1c95377
Compare
|
Build passes, moving to ready for review. |
Follow up on 13483 As previously reported in php#13483 (comment): > The parameter names seem to be incorrect. > > It should be `$status`, not `$code`. > > The RFC explicitly uses that parameter name in the proposal: https://wiki.php.net/rfc/exit-as-function#proposal > > It is also the name already used in the [manual](https://www.php.net/exit). > > Lastly, the parameter name `$status` better covers what can be passed: either a status _message_ or a status _code_. > While `$code` would read pretty weird when passing a message: > ```php > exit(code: 'message'); > ``` This commit attempts to fix this. Includes adding a test for exit/die using a named argument.
jrfnl
force-pushed
the
feature/fix-up-13483-exit-as-function-param-name
branch
from
1c95377
to
88ed90e
Compare
Girgias
approved these changes
Aug 16, 2024
Good to know. Keep in mind: I know next to nothing about C, so this really was me guessing what was needed 😂
Happens to the best of us. I'm just happy I noticed relatively quickly. Would have been a lot more awkward to fix in a few months time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #13483
As previously reported in #13483 (comment):
This commit attempts to fix this.
Includes adding a test for exit/die using a named argument.
P.S.: I hope I got it right, but can't test locally, so I'm opening this in draft to see the CI results and keeping my 🤞.