extend libxcrypt bindings #15870
Closed
extend libxcrypt bindings #15870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Sep 25, 2024
| @@ -2111,6 +2154,12 @@ function crc32(string $string): int {} | |||
| /** @refcount 1 */ | |||
| function crypt(#[\SensitiveParameter] string $string, string $salt): string {} | |||
|
|
|||
| function crypt_gensalt(?string $salt = null, int $count = 0): ?string {} | |||
There was a problem hiding this comment.
The first parameter should likely be called $prefix instead of $salt.
|
|
||
| function crypt_preferred_method(): ?string {} | ||
|
|
||
| function crypt_checksalt(string $salt): int {} |
There was a problem hiding this comment.
And here the parameter should probably be called $settings. Also affects the C code, which uses prefix.
| if (crypt_gensalt_rn(prefix, (unsigned long)count, NULL, 0, salt, CRYPT_GENSALT_OUTPUT_SIZE)) { | ||
| RETURN_STRING(salt); | ||
| } | ||
| RETURN_NULL(); |
There was a problem hiding this comment.
This should probably throw an Exception, similarly to how password_hash() will either succeed or throw.
|
Closing in favor of #17093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take benefit of latest lilbxcrypt 4.x
Add 3 functions:
crypt_gensaltcrypt_preferred_methodcrypt_checksalt(libxcrypt >= 4.3)Add
CRYPT_PREFIX_*andCRYPT_SALT_*constantsAdd 3 more hashing methods
This make using crypt much easier, without any mess about salt
This is compatible, when algo exists, with password_hash methods.
ONly a PoC for now
TODO: