test to function openssl_csr_export_to_file();

[marcosptf]

new test to don't covered function;

[bukka]

Please could you rewrite this and other openssl tests as well in the same way as #1600 . In this case, you can do for example something like:

var_dump(openssl_csr_export_to_file($csr, $crs_exported_file_notext_true, true));
var_dump(file_exists($crs_exported_file_notext_true));

Also don't forget to do --CLEAN-- if you create a new file to unlink it after the test.

And use tabs if you indent (no spaces)!

[marcosptf]

@bukka
done!

:-)

[jerrygrey]

@marcosptf In --CLEAN-- you have unlink(__DIR__."/{$crs_exported_file_notext_true}"); which becomes __DIR__ ."/". __DIR__ . DIRECTORY_SEPARATOR . "crs-exported-file-notext-true.crs" which is wrong. And you are still using spaces instead of tabs as @bukka pointed out a few times now.

[marcosptf]

@bukka @jerrygrey
fix done!
sorry, its will never happen again, thanks for everything!

[bukka]

The same here. I will take a look on this after PKCS12. There is some other stuff that needs to be tested.

[marcosptf]

👍

[krakjoe]

@marcosptf @bukka can we get an update here please ?

[bukka]

Please close it. I will come up with different test.