test to function openssl_get_md_methods();

[marcosptf]

a new test to show whats openssl md_methods are avaliables

[bukka]

The same as cipher algs test. It is incorrect as the list is dependent on installation...

[marcosptf]

Hi @bukka !
everything fine?

thanks for your review, i've fixed my mistake;
:-)

[bukka]

please remove this

[jerrygrey]

Couldn't this be more simpler?

...
--FILE--
<?php
var_dump(is_array(openssl_get_md_methods(true)));
var_dump(is_array(openssl_get_md_methods(false)));
?>
--EXPECT--
bool(true)
bool(true)

Also, would using empty() be better? Would it be bad if this method return an empty array?

[marcosptf]

Hi @jerrygrey how are you?
fine?

you are right, this way it's more simple, but i like show a message explain what was wrong if the test function fail.

Thanks for your comment!

:-)

[jerrygrey]

@marcosptf The test script will automatically provide an error message on failure, along with dffs, etc to make it easy to find out what went wrong, so those types of error messages are not really needed tbh.

[bukka]

tab instead of spaces pls

[marcosptf]

@bukka @jerrygrey
the changes is done

[jerrygrey]

@marcosptf Looks good, I don't see any issues with the code 👍

[marcosptf]

@bukka @jerrygrey
thanks for your support
👍

[marcioAlmada]

The history looks very confusing. How about squashing the commits here and also on #1601?

😉

[marcosptf]

@bukka @jerrygrey
done!

[bukka]

@marcosptf
It looks good. Could you open a new PR with just one commit containing this and #1601 so I can cherry pick it and you will stay as an author... ;)

I think there are actually some md algs that is not possible compile OpenSSL without (e.g. md5 - even no-md5 options is there - think it fails - I'll give a try) so I will add them later on top of your commit.

[marcosptf]

Hi @bukka

let me see if i understand.
i need create a new PR, with this test "array openssl_get_md_methods ([ bool $aliases = false ] );" plus this test "array openssl_get_cipher_methods ([ bool $aliases = false ] );" ???

but, is correct write a test file to two functions?

explain to me please

Thanks for your patience!

:-)

[jerrygrey]

@marcosptf No, keep the two tests in two different test files, @bukka just wants them both on one PR with one commit, it is just to keep everything nice and tidy on here.

[bukka]

@marcosptf Exactly as @jerrygrey says . One PR with one commit containing two files.

[marcosptf]

@bukka @jerrygrey
like this ==> #1612 ???

:D

[jerrygrey]

@marcosptf 👍

[marcosptf]

Hi @bukka @jerrygrey,
i would like to know, if you can see another PR?
to see if i did something wrong or it's correct
is this PR ===> #1553

i'm waiting for your comments
thanks so much!

:-)

[php-pulls]

Comment on behalf of bukka at php.net:

Part of PR #1612 - closing