OpenSSL AEAD support #1716
OpenSSL AEAD support #1716
Conversation
These ciphers are not added by OpenSSL_add_all_algorithms in 1.0.1
There has never been any warning for that
|
I plan to do a bit more testing later but works fine with 1.0.2 (will need to test older versions if disabling and skipping works fine) |
|
Thanks ! 👍 |
|
Please, don't merge PRs with convoluted history, squash the changes into one commit instead. |
|
I prefer not to squash it. At least I don't see any requirement for that in https://wiki.php.net/vcs/gitworkflow. However I should have rebased I guess so sorry for that. |
See: * http://php.net/manual/en/migration71.new-features.php#migration71.new-features.support-for-aead-in-ext-openssl * https://wiki.php.net/rfc/openssl_aead At the time of opening this issue, the new parameters weren't documented yet in the PHP documentation of the affected functions. * http://php.net/manual/en/function.openssl-encrypt.php * http://php.net/manual/en/function.openssl-decrypt.php PR based on the RFC and the merged PR php/php-src#1716. Includes unit tests.
See: * http://php.net/manual/en/migration71.new-features.php#migration71.new-features.support-for-aead-in-ext-openssl * https://wiki.php.net/rfc/openssl_aead At the time of opening this issue, the new parameters weren't documented yet in the PHP documentation of the affected functions. * http://php.net/manual/en/function.openssl-encrypt.php * http://php.net/manual/en/function.openssl-decrypt.php PR based on the RFC and the merged PR php/php-src#1716. Includes unit tests.
|
Any updates on ocb support ? Took me quiet some time to figure out why ocb is not working. Because openssl_get_cipher_methods() returns "aes-256-ocb". https://wiki.php.net/rfc/openssl_aead states "Future Scope: Adding support for ocb mode once the extension supports OpenSSL 1.1" Seems to me like ocb is supported and has to be implemented into the php wrapper. |
RFC: https://wiki.php.net/rfc/openssl_aead