Skip to content

Conversation

TimWolla
Copy link
Member

This is a follow-up for #17459, updating the command-line flag to not modify the behavior of --ini.


see https://externals.io/message/126303

This is a follow-up for php#17459, updating the command-line flag to
not modify the behavior of `--ini`.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure how opt parsing works TBH. If Jakub doesn't review soonish I'll go and dig into the code to properly understand it.

@cmb69
Copy link
Member

cmb69 commented Feb 17, 2025

Looks good to me. (An alternative might be to add --ini-diff.)

Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@TimWolla TimWolla merged commit 057ff35 into php:master Mar 4, 2025
9 checks passed
@TimWolla TimWolla deleted the ini-diff branch March 4, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants