uri: Improve exceptions for Uri\WhatWg\Url #18855
Open
+45
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Jun 18, 2025
| zend_throw_exception_object(&exception); | ||
| } | ||
|
|
||
| static void throw_invalid_url_exception_during_write(zval *errors) |
There was a problem hiding this comment.
Why did you get rid of this function? It seems useful 🤔 especially now that 3 lines are copy-pasted 8 times
There was a problem hiding this comment.
When using a different message for each component I felt that just copying the code was easier than trying to pass along the error message correctly to the helper function (especially when needing additional component-specific placeholders, I initially included the broken value in the message itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.