allow to build with system liburiparser

[remicollet]

To avoid another bundled library

Test suite with version 0.9.8 passes

Notice: It seems the bundled version is not really 0.9.8, but rather a git snapshot

New build option --with-external-uriparser (as we already have --with-external-gd and --with-external-libcrypt)
Use bundled sources by default.

[TimWolla]

Test suite with version 0.9.8 passes

That's likely because the library is not actually used yet. See #18836. The current git HEAD of uriparser contains some fixes contributed by Máté.

[remicollet]

That's likely because the library is not actually used yet

:(

BTW, I think we should allow building with system libraries, and bundled libraries should be exceptional

It seems a new version (0.9.9) will required (and we should encourage upstream to release it with needed patches)

[TimWolla]

It seems a new version (0.9.9) will required

Yes.

(and we should encourage upstream to release it with needed patches)

Yes, once all the necessary changes are included upstream.

[kocsismate]

It seems a new version (0.9.9) will required (and we should encourage upstream to release it with needed patches)

Yes, 0.9.9 will likely be the next release for sure according to this review suggestion: uriparser/uriparser#230 (comment)

[TimWolla]

@remicollet You can update this one after #19711 is merged.

[remicollet]

@remicollet You can update this one after #19711 is merged.

rebased and version bump to 0.9.9

Tested locally with system liburiparser 0.9.9
Test suite passes

[TimWolla]

Looks correct. Requesting review from Máté and the RMs.

[TimWolla]

Test suite passes

@remicollet Note that the setters will only arrive with #19636, but I don't expect any further upstream patches.

[DanielEScherzer]

RM approval, technical review not performed, noticed what I think is a typo if you want to address it

[krakjoe]

nit: others use "external" only:

  [AS_HELP_STRING([--with-external-gd],
    [Use external libgd])],

This seems correct, because it might be the system one (it might not), but it's definitely external.

[remicollet]

@TimWolla please review again for you change in phpinfo

[TimWolla]

Thanks, that makes sense to me.

[remicollet]

Thanks for the reviews