Skip to content

Conversation

TimWolla
Copy link
Member

This is necessary for `clone()` which does not currently accept a
parameter-less syntax, unless fully-qualified.
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my syntax remark. Otherwise seems fine mostly.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions were answered and follow ups were proposed, so this LGTM

@TimWolla TimWolla merged commit ca49a7b into php:master Jun 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants