GH-19153: Validate #[\Attribute] targets
#19154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Targeting master for the same reason as #15733 did - this adds a new error where previously there wasn't one until you tried to make use of the attribute, at which point ReflectionAttribute::newInstance() would complain that you can't instantiate a trait/enum/interface/abstract class |
iluuu1994
reviewed
Jul 17, 2025
|
I plan to merge this in a few days if there are no objections |
|
The implementation looks correct. I'm not sure whether a short e-mail to internals@ is warranted, since this could break working code. https://3v4l.org/8Lih3#v8.4.10 |
|
Discussion at https://news-web.php.net/php.internals/128229 |
TimWolla
reviewed
Jul 28, 2025
DanielEScherzer
force-pushed
the
validate-attribute-attribute
branch
from
6f57d75 to
012b0f9
Compare
Do not allow #[\Attribute] on traits, interfaces, enums, or abstract classes.
DanielEScherzer
force-pushed
the
validate-attribute-attribute
branch
from
012b0f9 to
ce3a659
Compare
TimWolla
reviewed
Aug 11, 2025
There was a problem hiding this comment.
This should probably also be in UPGRADING, since it's technically a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow
#[\Attribute]on traits, interfaces, enums, or abstract classes.