Skip to content

ext/spl: Deprecate ArrayObject and ArrayIterator with objects #19420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

ext/spl: Deprecate ArrayObject and ArrayIterator with objects #19420

merged 1 commit into from
Aug 14, 2025
+351 −134

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 8, 2025

@Girgias Girgias marked this pull request as ready for review August 9, 2025 10:22
@Girgias Girgias requested a review from bukka as a code owner August 9, 2025 10:22
@Girgias Girgias requested a review from iluuu1994 August 9, 2025 10:23
DanielEScherzer
DanielEScherzer approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@DanielEScherzer DanielEScherzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly prefer renaming the tests in a separate commit, but the actual changes look good

@DanielEScherzer DanielEScherzer mentioned this pull request Aug 13, 2025
Open
16 tasks
iluuu1994
iluuu1994 approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Girgias Girgias merged commit fb87b14 into php:master Aug 14, 2025
9 checks passed
@Girgias Girgias deleted the spl-array-object-dep branch August 14, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@DanielEScherzer DanielEScherzer DanielEScherzer approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: spl Extension: standard RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @iluuu1994 @DanielEScherzer