uri: Fix handling of the errors == NULL && !silent for uri_parser_whatwg
#19748
+57
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hatwg Previously, when `errors` was `NULL`, the `errors` pointer was used to set the `$errors` property when throwing the exception, leading to a crash. Use a local zval to pass the errors to the Exception and copy it into the `errors` input when it is non-`NULL`.
…stantiate_uri()` This is no longer necessary since the previous commit and also is a layering violation, since `php_uri_instantiate_uri()` should not care how `parse_uri()` works internally.
nielsdos
reviewed
Sep 7, 2025
nielsdos
approved these changes
Sep 7, 2025
kocsismate
approved these changes
Sep 8, 2025
|
Test failures are all due to the known ext/intl leak. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.