Fix CGI with auto_globals_jit=0 #19870
Open
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to call zend_is_auto_global(), which will read the uninitialized armed field. If the env is not yet initialized, we'll fall back to php_php_import_environment_variables().
iluuu1994
force-pushed
the
fix-cgi-auto_globals_jit=0
branch
from
147bfc8 to
5bfb86f
Compare
|
@bukka Also added you as a reviewer since this code is quite similar to php-fpm. So you might have the most real experience with this code. 🙂 |
|
I remember fixing something related in FPM but will need to refresh my mind and double check it. I plan to also look into those argc deprecation changes and logic around that to see if anything could be improved there. I should have a slot for this in a week starting Oct 7. |
|
@bukka Thanks. This currently breaks nightly, I'd prefer not to keep it red for so long. Maybe we can merge this for master now and backport later, once you've verified? |
@iluuu1994 Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to call zend_is_auto_global(), which will read the uninitialized armed field. If the env is not yet initialized, we'll fall back to php_php_import_environment_variables().
See https://github.com/php/php-src/actions/runs/17815318830/job/50647381504. Exposed by GH-19833.