uri: Update to uriparser-0.9.9-21-g08df3b2 #19992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is specifically to backport uriparser/uriparser#265. Fixes php#19897.
edorian
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
No RM objections, please note this also need approval from @DanielEScherzer given that we're in the RC phase.
kocsismate
approved these changes
Sep 29, 2025
DanielEScherzer
approved these changes
Oct 6, 2025
| * the size header. | ||
| * memory->reallocarray is uriEmulateReallocarray. | ||
| * <ul> | ||
| * <li><c>memory->calloc</c> is <c>uriEmulateCalloc</c>.</li> |
There was a problem hiding this comment.
not sure about some of this > escaping but if that is what upstream does...
There was a problem hiding this comment.
Yes. This is a straight copy and paste from upstream's src/ and include/ directories (only ext/uri/uriparser/src/UriConfig.h is generated from ext/uri/uriparser/src/UriConfig.h.in).
|
CI failures are due to 08924cd. Merging. |
TimWolla
added a commit
that referenced
this pull request
Oct 6, 2025
* PHP-8.5: uri: Update to uriparser-0.9.9-21-g08df3b2 (#19992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested Remi's and RM review, because of the updated minimum version for an external uriparser library. Given that the URI extension is completely new, I believe it's best to ship with the “best possible” version of uriparser to make a good first impression.
This is specifically to backport uriparser/uriparser#265.
Fixes #19897.