ext/sockets: socket_recvfrom() improve error message when port argument is missing #20069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Oct 5, 2025
| --TEST-- | ||
| socket_recvfrom() with IPv6 socket missing port argument | ||
| --EXTENSIONS-- | ||
| sockets |
There was a problem hiding this comment.
nit: I think you need ipv6_skipif.inc for this one.
TimWolla
reviewed
Oct 5, 2025
| if (arg6 == NULL) { | ||
| zend_string_efree(recv_buf); | ||
| WRONG_PARAM_COUNT; | ||
| zend_argument_value_error(6, "must be specified when argument #1 ($socket) is of type AF_INET or AF_INET6"); |
There was a problem hiding this comment.
I believe this should stay ArgumentCountError, especially since it's an out parameter.
How about:
socket_recvfrom() expects exactly 6 arguments when argument #1 ($socket) is of type AF_INET or AF_INET6, $x given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract sockets changes from #20066