Fix #72733: [RFC] Expose getaddrinfo C function, and supporting connect/bind #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature request was to expose getaddrinfo(). I accomplish this by having an array of resources that are the addrinfo structures. The resources can be used in new functions to connect/bind, and one function to examine the contents of the resource.
…an struct sockaddr
bp1222
changed the title
| hints.ai_protocol = Z_LVAL_P(hint); | ||
| } else if (strcmp(ZSTR_VAL(key), "ai_family") == 0) { | ||
| hints.ai_family = Z_LVAL_P(hint); | ||
| } |
There was a problem hiding this comment.
All of these should be using zval_get_long instead of Z_LVAL_P, otherwise you'll get crashes if other types are used. Additionally the key comparisons should preferably use zend_string_equals_literal to be pedantic about nul bytes.
There was a problem hiding this comment.
Yes, since hints is an array, nothing is previously checking to make sure that they are in fact decent long values. I follow you on that. I assume the same with the move away from strcmp(), which I'll change
|
@nikic - Since this branch has been merged, should I create a new PR with these fixes? |
|
@bp1222 Yeah, that would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request was to expose getaddrinfo(). I accomplish this
by having an array of resources that are the addrinfo structures.
The resources can be used in new functions to connect/bind, and
one function to examine the contents of the resource.
[RFC] - https://wiki.php.net/rfc/socket_getaddrinfo