New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sporadic segfault with MYSQLI_OPT_INT_AND_FLOAT_NATIVE #2249

Closed
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@vanviegen
Contributor

vanviegen commented Dec 21, 2016

Fixes bug #73800

@php-pulls

This comment has been minimized.

Show comment
Hide comment
@php-pulls

php-pulls Dec 21, 2016

Comment on behalf of krakjoe at php.net:

labelling

php-pulls commented Dec 21, 2016

Comment on behalf of krakjoe at php.net:

labelling

@php-pulls php-pulls added the Bugfix label Dec 21, 2016

php-pulls pushed a commit that referenced this pull request Jan 2, 2017

@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 2, 2017

Member

Merged abba56f dfb6cdb

Thanks.

Member

krakjoe commented Jan 2, 2017

Merged abba56f dfb6cdb

Thanks.

@krakjoe krakjoe closed this Jan 2, 2017

php-pulls pushed a commit that referenced this pull request Jan 2, 2017

Merge branch 'PHP-7.1'
* PHP-7.1:
  Fix for sporadic segfault with MYSQLI_OPT_INT_AND_FLOAT_NATIVE
  news entry for PR #2249
@mhagstrand

This comment has been minimized.

Show comment
Hide comment
@mhagstrand

mhagstrand Jan 2, 2017

Contributor

I'm looking at this I don't think this should have been merged into PHP 7.1 and master. The other merge in #2250 in PHP7.0 looks ok but this seems to be causing a failure in ext/mysqli/tests/bug71863.phpt

https://travis-ci.org/php/php-src/jobs/188285402

========DIFF========
001+ Warning: mysqli_query(): (42S22/1054): Unknown column 'owner_id' in 'where clause'� in /home/travis/build/php/php-src/ext/mysqli/tests/bug71863.php on line 11
001- %AUnknown column 'owner_id' in 'where clause'
002+ Unknown column 'owner_id' in 'where clause'�
========DONE========

It looks like 9eca4dc fixed the issue and now this commit is causing an off by one error.

Contributor

mhagstrand commented Jan 2, 2017

I'm looking at this I don't think this should have been merged into PHP 7.1 and master. The other merge in #2250 in PHP7.0 looks ok but this seems to be causing a failure in ext/mysqli/tests/bug71863.phpt

https://travis-ci.org/php/php-src/jobs/188285402

========DIFF========
001+ Warning: mysqli_query(): (42S22/1054): Unknown column 'owner_id' in 'where clause'� in /home/travis/build/php/php-src/ext/mysqli/tests/bug71863.php on line 11
001- %AUnknown column 'owner_id' in 'where clause'
002+ Unknown column 'owner_id' in 'where clause'�
========DONE========

It looks like 9eca4dc fixed the issue and now this commit is causing an off by one error.

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Jan 2, 2017

Member

Hopefully 43ed89e will resolve the test failure.

Member

nikic commented Jan 2, 2017

Hopefully 43ed89e will resolve the test failure.

@vanviegen

This comment has been minimized.

Show comment
Hide comment
@vanviegen

vanviegen Jan 3, 2017

Contributor

Ouch! I guess my C days have now officially expired. Sorry everyone, thanks @nikic!

Contributor

vanviegen commented Jan 3, 2017

Ouch! I guess my C days have now officially expired. Sorry everyone, thanks @nikic!

@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 3, 2017

Member

No need to be sorry, easy mistake to make and no harm done :)

Member

krakjoe commented Jan 3, 2017

No need to be sorry, easy mistake to make and no harm done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment