New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sporadic segfault with MYSQLI_OPT_INT_AND_FLOAT_NATIVE #2250

Closed
wants to merge 1 commit into
base: PHP-7.0
from

Conversation

4 participants
@vanviegen
Contributor

vanviegen commented Dec 21, 2016

Fixes bug #73800

@php-pulls

This comment has been minimized.

Show comment
Hide comment
@php-pulls

php-pulls Dec 21, 2016

Comment on behalf of krakjoe at php.net:

labelling

php-pulls commented Dec 21, 2016

Comment on behalf of krakjoe at php.net:

labelling

@php-pulls php-pulls added the Bugfix label Dec 21, 2016

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Dec 21, 2016

Member

You mentioned on the bug report that this issue is not reproducible deterministically. Maybe it would be possible to create a test that consistently generates a warning when run under valgrind?

Otherwise the fix looks correct (though imho what we're doing in read_text_protocol_aux is horrible and we might want to copy the values to a stack buffer for conversion instead).

Member

nikic commented Dec 21, 2016

You mentioned on the bug report that this issue is not reproducible deterministically. Maybe it would be possible to create a test that consistently generates a warning when run under valgrind?

Otherwise the fix looks correct (though imho what we're doing in read_text_protocol_aux is horrible and we might want to copy the values to a stack buffer for conversion instead).

php-pulls pushed a commit that referenced this pull request Jan 2, 2017

@krakjoe

This comment has been minimized.

Show comment
Hide comment
@krakjoe

krakjoe Jan 2, 2017

Member

Merged 732f67e

Thanks.

Member

krakjoe commented Jan 2, 2017

Merged 732f67e

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment