Update basic functions to new parameter parsing API #2565
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Err, aren't you moving from the new to the old API here? |
This reverts commit 99c0220.
|
We just pretend it never happened. 😉 |
|
Looks like an obvious case to squash |
|
This can easily be done on merge, or would you guys prefer that I rewrite the history of this branch?!? |
|
i saw you removed some trailing white space in the commit you later reverted, definitely not relevant for this change but can someone consider cleaning up all the trailing space from the whole codebase? they are evil. (and yes, this is offtopic i know) |
|
Merged as 7cce220, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://news.php.net/php.internals/99436