Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add ftp_append to create a new file or append data to an existing file (RFC959) #2615
Okay, correction. The aginfos on PHP-7.2 do match their function implementations, so this diff, as it stands, is wrong. The arginfos shouldn't be updated without also updating the implementations. At that point the change becomes much less self-contained.
At this point, I would say: Make the new function require the mode argument for consistency with the other ftp functions. Remove the changes to their arginfos, and plan to make mode optional in 7.3