Skip to content

Conversation

carusogabriel
Copy link
Contributor

Following #2995, I've now cleaned up our .h files 🚮

Again, something that will help review: passing ?w=1 to Files Changed tab, ensures that all files only contains Whitespace-only changes..

Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@php-pulls php-pulls merged commit 6687e8d into php:master Jan 4, 2018
@carusogabriel carusogabriel deleted the clean-up branch January 4, 2018 06:33
@KalleZ
Copy link
Member

KalleZ commented Jan 4, 2018

@laruence @carusogabriel this PR changes files thats generated like the credits files that will otherwise override this PR's changes later on and bundled libraries (like sqlite, libmagic, zip and pcre) -- those should probably go upstream if anything, as the next update will override it again. Note that mbstring doesn't need this, as we use a heavily modified version

This was referenced Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants