Trailing whitespaces #2995
Closed
Trailing whitespaces #2995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
|
Big thanks to @javiereguiluz’s tip that I'll help review: passing |
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
|
Comment on behalf of cmb at php.net: Thanks, Gabriel. I've applied the PR in 6400264. And yes, all non-bug-fixes should target master. |
Merged
This was referenced Jan 24, 2018
Closed
This was referenced Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
With this PR, I've cleaned up the whole whitespaces in
php-srcC files 🚮If this gets accepted, would be my pleasure to run with other types of file 😄
(I just don't know if I committed in the right branch 😅)