Skip to content

Use bool instead of boolean in proto #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use bool instead of boolean in proto #3067

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

Following #3051

@nikic
Copy link
Member

nikic commented Feb 4, 2018

If you're up for it, the error messages that PHP throws for type errors currently also use incorrect names for integer and boolean. It would be good to fix that, but it's going to take a lot of test updates. The relevant function for this is:

php-src/Zend/zend_API.c

Line 102 in 5c77bac

ZEND_API char *zend_get_type_by_const(int type) /* {{{ */

@carusogabriel
Copy link
Contributor Author

@nikic So please merge this one, and I'll work on that in a separate one 🚧

@carusogabriel carusogabriel mentioned this pull request Feb 4, 2018
Closed
@nikic
Copy link
Member

nikic commented Feb 4, 2018

Merged as affc20f, thanks.

@nikic nikic closed this Feb 4, 2018
@carusogabriel carusogabriel deleted the boolean branch February 4, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carusogabriel @nikic