Use int instead of integer while throwing a type error #3071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I very much like that, but see https://externals.io/message/100716. |
|
@carusogabriel At least a discussion on internals appears to be appropriate. |
|
The error message change will not need an internals discussion. However, we do need to avoid changes to gettype() output. I believe reverting the change on https://github.com/php/php-src/pull/3071/files#diff-83f183e96550026d1885396c513138d2L415 should be enough for that. |
|
Merged as ce1d69a with some more gettype related test changes reverted. Thanks for pulling this massive change through :) |
|
Working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @nikic's #3067 (comment)