Skip to content

Use bool instead of boolean while throwing a type error #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use bool instead of boolean while throwing a type error #3073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/tests/008.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ Warning: define() expects at least 2 parameters, 1 given in %s on line %d
NULL
bool(true)

Warning: define() expects parameter 3 to be boolean, array given in %s on line %d
Warning: define() expects parameter 3 to be bool, array given in %s on line %d
NULL

Warning: define() expects parameter 1 to be string, array given in %s on line %d
Expand Down
10 changes: 5 additions & 5 deletions Zend/tests/type_declarations/scalar_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,21 +257,21 @@ bool(true)
bool(false)

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type boolean, null given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, null given, called in %s on line %d

*** Trying array(0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, array given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, array given, called in %s on line %d

*** Trying object(stdClass)#%s (0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying object(Stringable)#%s (0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying resource(%d) of type (stream)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, resource given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, resource given, called in %s on line %d

Done
2 changes: 1 addition & 1 deletion Zend/tests/type_declarations/scalar_null.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Testing float:
Testing string:
*** Caught Argument 1 passed to {closure}() must be of the type string, null given, called in %s on line %d
Testing bool:
*** Caught Argument 1 passed to {closure}() must be of the type boolean, null given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, null given, called in %s on line %d
Testing int nullable:
NULL
Testing float nullable:
Expand Down
10 changes: 5 additions & 5 deletions Zend/tests/type_declarations/scalar_return_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,17 @@ bool(true)
*** Trying bool(false)
bool(false)
*** Trying NULL
*** Caught Return value of {closure}() must be of the type boolean, null returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, null returned in %s on line %d
*** Trying array(0) {
}
*** Caught Return value of {closure}() must be of the type boolean, array returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, array returned in %s on line %d
*** Trying object(stdClass)#6 (0) {
}
*** Caught Return value of {closure}() must be of the type boolean, object returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, object returned in %s on line %d
*** Trying object(Stringable)#7 (0) {
}
*** Caught Return value of {closure}() must be of the type boolean, object returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, object returned in %s on line %d
*** Trying resource(5) of type (stream)
*** Caught Return value of {closure}() must be of the type boolean, resource returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, resource returned in %s on line %d

Done
10 changes: 5 additions & 5 deletions Zend/tests/type_declarations/scalar_return_basic_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,17 @@ bool(true)
*** Trying bool(false)
bool(false)
*** Trying NULL
*** Caught Return value of {closure}() must be of the type boolean, null returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, null returned in %s on line %d
*** Trying array(0) {
}
*** Caught Return value of {closure}() must be of the type boolean, array returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, array returned in %s on line %d
*** Trying object(stdClass)#6 (0) {
}
*** Caught Return value of {closure}() must be of the type boolean, object returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, object returned in %s on line %d
*** Trying object(Stringable)#7 (0) {
}
*** Caught Return value of {closure}() must be of the type boolean, object returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, object returned in %s on line %d
*** Trying resource(5) of type (stream)
*** Caught Return value of {closure}() must be of the type boolean, resource returned in %s on line %d
*** Caught Return value of {closure}() must be of the type bool, resource returned in %s on line %d

Done
40 changes: 20 additions & 20 deletions Zend/tests/type_declarations/scalar_strict.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ int(2147483647)
*** Caught Argument 1 passed to {closure}() must be of the type int, float given, called in %s on line %d

*** Trying bool(true)
*** Caught Argument 1 passed to {closure}() must be of the type int, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type int, bool given, called in %s on line %d

*** Trying bool(false)
*** Caught Argument 1 passed to {closure}() must be of the type int, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type int, bool given, called in %s on line %d

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type int, null given, called in %s on line %d
Expand Down Expand Up @@ -147,10 +147,10 @@ float(2147483647)
float(NAN)

*** Trying bool(true)
*** Caught Argument 1 passed to {closure}() must be of the type float, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type float, bool given, called in %s on line %d

*** Trying bool(false)
*** Caught Argument 1 passed to {closure}() must be of the type float, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type float, bool given, called in %s on line %d

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type float, null given, called in %s on line %d
Expand Down Expand Up @@ -200,10 +200,10 @@ string(0) ""
*** Caught Argument 1 passed to {closure}() must be of the type string, float given, called in %s on line %d

*** Trying bool(true)
*** Caught Argument 1 passed to {closure}() must be of the type string, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type string, bool given, called in %s on line %d

*** Trying bool(false)
*** Caught Argument 1 passed to {closure}() must be of the type string, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type string, bool given, called in %s on line %d

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type string, null given, called in %s on line %d
Expand All @@ -226,31 +226,31 @@ string(0) ""
Testing 'bool' type:

*** Trying int(1)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, int given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, int given, called in %s on line %d

*** Trying string(1) "1"
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying float(1)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying float(1.5)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying string(2) "1a"
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying string(1) "a"
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying string(0) ""
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying int(2147483647)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, int given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, int given, called in %s on line %d

*** Trying float(NAN)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying bool(true)
bool(true)
Expand All @@ -259,21 +259,21 @@ bool(true)
bool(false)

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type boolean, null given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, null given, called in %s on line %d

*** Trying array(0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, array given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, array given, called in %s on line %d

*** Trying object(stdClass)#6 (0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying object(Stringable)#7 (0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying resource(5) of type (stream)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, resource given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, resource given, called in %s on line %d

Done
40 changes: 20 additions & 20 deletions Zend/tests/type_declarations/scalar_strict_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ int(9223372036854775807)
*** Caught Argument 1 passed to {closure}() must be of the type int, float given, called in %s on line %d

*** Trying bool(true)
*** Caught Argument 1 passed to {closure}() must be of the type int, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type int, bool given, called in %s on line %d

*** Trying bool(false)
*** Caught Argument 1 passed to {closure}() must be of the type int, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type int, bool given, called in %s on line %d

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type int, null given, called in %s on line %d
Expand Down Expand Up @@ -147,10 +147,10 @@ float(9.2233720368548E+18)
float(NAN)

*** Trying bool(true)
*** Caught Argument 1 passed to {closure}() must be of the type float, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type float, bool given, called in %s on line %d

*** Trying bool(false)
*** Caught Argument 1 passed to {closure}() must be of the type float, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type float, bool given, called in %s on line %d

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type float, null given, called in %s on line %d
Expand Down Expand Up @@ -200,10 +200,10 @@ string(0) ""
*** Caught Argument 1 passed to {closure}() must be of the type string, float given, called in %s on line %d

*** Trying bool(true)
*** Caught Argument 1 passed to {closure}() must be of the type string, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type string, bool given, called in %s on line %d

*** Trying bool(false)
*** Caught Argument 1 passed to {closure}() must be of the type string, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type string, bool given, called in %s on line %d

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type string, null given, called in %s on line %d
Expand All @@ -226,31 +226,31 @@ string(0) ""
Testing 'bool' type:

*** Trying int(1)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, int given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, int given, called in %s on line %d

*** Trying string(1) "1"
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying float(1)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying float(1.5)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying string(2) "1a"
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying string(1) "a"
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying string(0) ""
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying int(9223372036854775807)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, int given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, int given, called in %s on line %d

*** Trying float(NAN)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying bool(true)
bool(true)
Expand All @@ -259,21 +259,21 @@ bool(true)
bool(false)

*** Trying NULL
*** Caught Argument 1 passed to {closure}() must be of the type boolean, null given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, null given, called in %s on line %d

*** Trying array(0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, array given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, array given, called in %s on line %d

*** Trying object(stdClass)#6 (0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying object(Stringable)#7 (0) {
}
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying resource(5) of type (stream)
*** Caught Argument 1 passed to {closure}() must be of the type boolean, resource given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, resource given, called in %s on line %d

Done
26 changes: 13 additions & 13 deletions Zend/tests/type_declarations/scalar_strict_basic.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ int(1)
*** Caught Argument 1 passed to {closure}() must be of the type int, string given, called in %s on line %d

*** Trying true value
*** Caught Argument 1 passed to {closure}() must be of the type int, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type int, bool given, called in %s on line %d

*** Trying false value
*** Caught Argument 1 passed to {closure}() must be of the type int, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type int, bool given, called in %s on line %d

*** Trying null value
*** Caught Argument 1 passed to {closure}() must be of the type int, null given, called in %s on line %d
Expand All @@ -103,10 +103,10 @@ float(1)
*** Caught Argument 1 passed to {closure}() must be of the type float, string given, called in %s on line %d

*** Trying true value
*** Caught Argument 1 passed to {closure}() must be of the type float, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type float, bool given, called in %s on line %d

*** Trying false value
*** Caught Argument 1 passed to {closure}() must be of the type float, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type float, bool given, called in %s on line %d

*** Trying null value
*** Caught Argument 1 passed to {closure}() must be of the type float, null given, called in %s on line %d
Expand All @@ -132,10 +132,10 @@ Testing 'string' type:
string(1) "1"

*** Trying true value
*** Caught Argument 1 passed to {closure}() must be of the type string, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type string, bool given, called in %s on line %d

*** Trying false value
*** Caught Argument 1 passed to {closure}() must be of the type string, boolean given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type string, bool given, called in %s on line %d

*** Trying null value
*** Caught Argument 1 passed to {closure}() must be of the type string, null given, called in %s on line %d
Expand All @@ -152,13 +152,13 @@ string(1) "1"
Testing 'bool' type:

*** Trying integer value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, int given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, int given, called in %s on line %d

*** Trying float value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, float given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, float given, called in %s on line %d

*** Trying string value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, string given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, string given, called in %s on line %d

*** Trying true value
bool(true)
Expand All @@ -167,15 +167,15 @@ bool(true)
bool(false)

*** Trying null value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, null given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, null given, called in %s on line %d

*** Trying array value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, array given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, array given, called in %s on line %d

*** Trying object value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, object given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, object given, called in %s on line %d

*** Trying resource value
*** Caught Argument 1 passed to {closure}() must be of the type boolean, resource given, called in %s on line %d
*** Caught Argument 1 passed to {closure}() must be of the type bool, resource given, called in %s on line %d

Done
Loading