Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bool instead of boolean while throwing a type error #3073

Closed
wants to merge 1 commit into from
Closed

Use bool instead of boolean while throwing a type error #3073

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

Following #3071, now with boolean

@nikic
Copy link
Member

nikic commented Feb 4, 2018

Merged as fef879a. Thanks!

@nikic nikic closed this Feb 4, 2018
@nikic
Copy link
Member

nikic commented Feb 4, 2018

A couple of follow-up changes in b4dff68 and fc23452.

@carusogabriel carusogabriel deleted the boolean branch February 4, 2018 22:36
@carusogabriel
Copy link
Contributor Author

@nikic Anything else related that I can help? 😊

@carusogabriel carusogabriel mentioned this pull request Feb 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carusogabriel @nikic