Trailing whitespaces in inc files #3091
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
approved these changes
Feb 10, 2018
|
Merged as 21e3b0c, thanks. |
|
@nikic Can we merge this kind of changes to the 7.1 and up? I'm currently working on the complete rewrite of fpm tests which I would like merge to 7.1 (or 7.2 if I'm too slow :) ) once it is done. The reason is that I would like to use it for fixes that I will apply to the lower branch so I don't have to do 2 tests (old and new). This is obviously causing conflict for me. I can of course resolve it in this case but think that it would be better to apply such changes to the lower branches to prevent even more conflicts. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2995