Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement new custom object serialization mechanism #3761
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
Merged as d373c11. |
This comment has been minimized.
This comment has been minimized.
|
For reference, I opened https://bugs.php.net/77866: internal Serializable classes should implement the new __(un)serialize methods, isn't it? |
This comment has been minimized.
This comment has been minimized.
yitam
commented
Jun 22, 2019
|
Not sure if this is the right place to ask about __wakeup() and __sleep() being removed from pdo pdo_dbh.c and pdo_stmt.c. In the aforementioned RFC it said "no particular pressing need to phase out __sleep() and __wakeup()". Please advice. |
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Aug 20, 2019
> A new mechanism for custom object serialization has been added, which uses two new magic methods: > > ```php > // Returns array containing all the necessary state of the object. > public function __serialize(): array; > > // Restores the object state from the given data array. > public function __unserialize(array $data): void; > ``` > > The new serialization mechanism supersedes the Serializable interface, which will be deprecated in the future. Refs: * https://wiki.php.net/rfc/custom_object_serialization * https://github.com/php/php-src/blob/3775d47eee38f3b34f800a0b23f840ec7a94e4c7/UPGRADING#L305-L315 * php/php-src#3761 * php/php-src@d373c11 Includes unit tests. Related to 808
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Aug 20, 2019
From the RFC: > **Creating objects in __unserialize()** > > Some people have expressed a desire to make __unserialize() a static method which creates and returns the unserialized object (rather than first constructing the object and then calling __unserialize() to initialize it). > > This would allow an even greater degree of control over the serialization mechanism, for example it would allow to return an already existing object from __unserialize(). > > However, allowing this would once again require immediately calling __unserialize() functions (interleaved with unserialization) to make the object available for backreferences, which would reintroduce some of the problems that Serializable suffers from. As such, this will not be supported. Refs: * https://wiki.php.net/rfc/custom_object_serialization * https://github.com/php/php-src/blob/3775d47eee38f3b34f800a0b23f840ec7a94e4c7/UPGRADING#L305-L315 * php/php-src#3761 * php/php-src@d373c11 Includes unit tests. Related to 808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nikic commentedJan 23, 2019
•
edited
RFC: https://wiki.php.net/rfc/custom_object_serialization