Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony back in the community test suite #4666

Closed
wants to merge 2 commits into from

Conversation

@nicolas-grekas
Copy link
Contributor

commented Sep 2, 2019

It was disabled in #1054, but this should make it OK.
Feel free to ping me when you have any issue with this test suite, I'd be happy to help maintain it.

@carusogabriel carusogabriel added the Tests label Sep 2, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

I'm not sure where I should read the output for the related jobs? Could anyone point me at past ones?

@nikic

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Symfony is still enabled on 7.4, the reason why I dropped it on master is that phpunit doesn't install due to platform requirements (it is not compatible with PHP 8 and there is no way to pass --ignore-platform-reqs). Unless this got fixed in the phpunit wrapper, this issue will appear again.

You can edit https://github.com/php/php-src/blob/master/azure-pipelines.yml and drop everything but the community job to check whether it works. It's not run on pull request builds.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:test-symfony branch from be343c7 to 061550d Sep 2, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

it is not compatible with PHP 8 and there is no way to pass --ignore-platform-reqs

got it, the attached patch should work around the issue, don't you think?

@nikic

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

What is the relation between flex and the memory_limit? We can also change the memory_limit.

It is possible to run php7.3 ./phpunit install? I'd guess that would avoid both the PHP version issue and be faster. I just didn't realize that the installation part could be run separately from the tests.

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

What is the relation between flex and the memory_limit?

When there are too many legacy tags, the matrix explodes, see symfony/flex#378 which introduced the workaround exactly for this reason.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:test-symfony branch from e33ce5a to 3eace42 Sep 2, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

I pushed symfony/symfony@62020ab on the bridge to give it the flexibility we need here.

Be careful if you want to do further tweaks, I push-forced on my branch.

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:test-symfony branch from 3eace42 to 6f0bde4 Sep 2, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:test-symfony branch from 6f0bde4 to e9bdd81 Sep 2, 2019

@nikic

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Yay, looks like it works.

Also one ubsan warning (also on 7.4 but got lost in the log): ./home/vsts/work/1/s/ext/standard/random.c:238:13: runtime error: signed integer overflow: 9223372036854775807 - -9223372036854775808 cannot be represented in type 'long int'

Should probably configure it to abort instead of only printing a message.

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Cool! What's the next step? There are failures, errors, deprecation notices (a bunch of them, dunno why as I don't have them on 7.3)

@KalleZ

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

The next step should just be to merge it, we don’t really care about deprecations, notices etc on a userland level but the results of the ub tooling on the test suites :)

@nikic

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Partially backported via #4672 and then merged up. The symfony run was successful in https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=2567.

@nikic nikic closed this Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.