Allow substr functions to accept null lengths #4840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Oct 21, 2019
nikic
reviewed
Oct 21, 2019
colinodell
force-pushed
the
substr-null-length
branch
from
58ae51c
to
f41a353
Compare
If a null $length is passed to any of these functions, behave as if no parameter was passed: - substr() - substr_count() - substr_compare() - iconv_substr()
colinodell
force-pushed
the
substr-null-length
branch
from
f41a353
to
6a4532b
Compare
colinodell
changed the title
|
There were three other |
nikic
approved these changes
Oct 22, 2019
This was referenced Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the
*substr*class of functions to accept a null length just likemb_substr()does. This includes:substr()substr_count()substr_compare()iconv_substr()Original discussion: https://externals.io/message/107600