Document the changes to substr functions #4843
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Oct 22, 2019
UPGRADING
Outdated
| @@ -271,6 +271,10 @@ PHP 8.0 UPGRADE NOTES | |||
| point. An explicit call to chr() can be used to restore the previous | |||
| behavior. | |||
| . The needle argument for strpos(), strrpos(), stripos(), strripos(), strstr() and stristr() can now be empty. | |||
| . The length argument for substr(), substr_count(), substr_compare(), and | |||
| iconv_substr() can now be null. Null values will be behave as if no length | |||
There was a problem hiding this comment.
I believe the 2nd be is a typo here!
There was a problem hiding this comment.
Good catch! This has been fixed.
colinodell
force-pushed
the
document-substr-changes
branch
from
1702fc8 to
2b87e5d
Compare
|
Merged as part of #4844. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the changes from #4840 in
UPGRADING.My apologies for not including these notes in that previous PR.