Fix #69264: __debugInfo() ignored while extending SPL classes #5333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to call `::__debugInfo()`, if defined for SPL descendants.
|
I would recommend actually implementing |
I agree that this is cleaner, but would be a BC break regarding the var_dump() output (see PR #5342). |
|
Closing in favor of PR #5342, which doesn't have the misbelieved BC issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to call
::__debugInfo(), if defined for SPL descendants.I have some doubts regarding the BC break, particularly since it would be no longer possible to call the inherited
::__debugInfo(), because it is actually not inherited; only theget_debug_infohandlers are implemented.Thoughts?