-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix #69264: __debugInfo() ignored while extending SPL classes #5342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We actually implement `::__debugInfo()` and drop the `get_debug_info()` handlers of all relevant SPL classes. This is cleaner and gives more flexibility regarding overriding the functionality in descendant classes.
Where does the difference come from? |
The
The current PR may also be incomplete or partially wrong. PS: it was the latter. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update stubs when merging :)
Thanks! Applied as 22a077b (and merged up, ugh). |
We actually implement
::__debugInfo()
and drop theget_debug_info()
handlers of all relevant SPL classes. This is cleaner and gives more
flexibility regarding overriding the functionality in descendant
classes.
This is an alternative solution to PR #5333. I'm afraid this can't be merged into PHP-7.4 because of the BC break (see failing tests).
PS: actually there is no real BC break.