[RFC] Support optional comma in closure use list #5793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
approved these changes
Jul 15, 2020
|
Vote looks good, feel free to already land to prevent the stampede right before feature freeze. I also sent a heads up about this at https://externals.io/message/110860#111094 so nobody complains. |
The release manager has agreed to allow merging of RFCs that have near-unanimous At the time of writing, there were 46 Yes votes and 0 No votes. |
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Jul 30, 2020
…se lists PHP 8.0 introduced trailing comma's in function declaration parameter lists. A sniff to detect these was added via PR 1164. Since then, a new RFC has been voted on & accepted, to also allow trailing comma's in closure use lists. This adds an additional check to the `PHPCompatibility.FunctionDeclarations.NewTrailingComma` sniff to detect trailing comma's in closure `use` lists. Note: the error code for the original error message has been changed from `Found` to `InParameterList`, but as this sniff was only introduced recently and has not been released yet, this is not an BC-break. Refs: * https://wiki.php.net/rfc/trailing_comma_in_closure_use_list * php/php-src#5793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/trailing_comma_in_closure_use_list
Discussion: https://externals.io/message/110715