Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert resources to objects in ext/sockets #5900

Closed
wants to merge 8 commits into from
Closed

Convert resources to objects in ext/sockets #5900

wants to merge 8 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate marked this pull request as draft July 27, 2020 22:55
@Girgias Girgias mentioned this pull request Jul 27, 2020
Open
41 tasks
@Girgias
Copy link
Member

Girgias commented Jul 28, 2020

Compile error:

/home/vsts/work/1/s/ext/sockets/sockets.c:937:14: error: unused variable ‘php_sock’ [-Werror=unused-variable]
  937 |  php_socket *php_sock;
      |              ^~~~~~~~

nikic
nikic reviewed Jul 29, 2020
View reviewed changes
ext/sockets/sockets.c Outdated Show resolved Hide resolved
ext/sockets/sockets.c Show resolved Hide resolved
@kocsismate kocsismate added this to the PHP 8.0 milestone Jul 30, 2020
@kocsismate kocsismate marked this pull request as ready for review August 2, 2020 20:49
kocsismate
kocsismate commented Aug 2, 2020
View reviewed changes
ext/sockets/sockets.c Show resolved Hide resolved
ext/sockets/tests/socket_export_stream-1.phpt Outdated Show resolved Hide resolved
@php-pulls php-pulls closed this in 77172c2 Aug 3, 2020
@kocsismate kocsismate deleted the resource-sockets branch August 3, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

@bwoebi bwoebi bwoebi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kocsismate @Girgias @nikic @bwoebi