Allow objects in define() #7149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Jan 3, 2023
> `new` in Initializers > > [...] Objects can also be passed to `define()` now. Refs: * https://www.php.net/manual/en/migration81.new-features.php#migration81.new-features.core.new-in-initializer * php/php-src#7149 * php/php-src@53aed48 Includes unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of enums, constants using the
const X = Ysyntax can now contain objects. However,define()still prohibits use of objects. This relaxes the restriction.The
const X = Ysyntax currently only allows assigning enum objects in particular, simply because there is no syntactically supported way to create a different object. I don't see a point in restrictingdefine()to allow only enum objects in particular though.