Use "integer" and "float" rather than "long" and "double" in messages to users. #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouble'->'float' Fixes type names at Y in "X expects parameter A to be Y, but Z given" messages to be the types that PHP programmers would expect, rather than C types.
Fixes the second half of invalid parameter messages ending "... expected, but double given". Doesn't affect userland gettype() function, as that is defined independently. Also affects some Reflection output, e.g. summary of class constants. Other uses are mostly related to typehints, so cannot fall into this case.
Includes necessary test changes to match.
|
There is ongoing discussion about underlying type changes in PHP. See the branch https://github.com/php/php-src/tree/str_size_and_int64 |
|
I did this and got it merged (see #955), so this should probably be closed. |
|
Comment on behalf of ajf at php.net: Closed as #955 was already merged and makes this redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages mentioning "long" and "double" are confusing to users, as these are not the names used for the types in the manual or userland functions; they should refer to "integer" and "float", respectively.
This PR updates all the appropriate messages, and all PHPT tests expecting them (the tests make up the bulk of the changes).
I would consider this a bug fix, although there may be tools out there relying on the current wording. In particular, I noticed that echoing a whole class using reflection used the "wrong" terms (see changes to ext/reflection/tests/bug29986.phpt).
I've never submitted a pull request before, and made this change a while ago and then forgot about it, so let me know if I've not followed the correct process.