Skip to content

Use "integer" and "float" rather than "long" and "double" in messages to users. #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Use "integer" and "float" rather than "long" and "double" in messages to users. #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f22f71
Fix type names in zend_parse_parameters errors: 'long'->'integer', 'd…
IMSoP May 7, 2014
affd645
Change all tests to expect 'integer' and 'float' in parameter type er…
IMSoP May 7, 2014
81cd55e
Make zend_get_type_by_const say 'float' not 'double'
IMSoP May 7, 2014
03e78c0
Fix tests to expect 'float' from zend_get_type_by_const
IMSoP May 7, 2014
8dd601a
'double'->'float' in "Object ... could not be converted to ..."
IMSoP May 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Zend/tests/bug33999.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ object(Foo)#1 (1) {
Notice: Object of class Foo could not be converted to int in %sbug33999.php on line 9
int(1)

Notice: Object of class Foo could not be converted to double in %sbug33999.php on line 12
Notice: Object of class Foo could not be converted to float in %sbug33999.php on line 12
float(1)
2 changes: 1 addition & 1 deletion Zend/tests/cast_to_double.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ float(1)
float(0)
float(%d)

Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
float(1)
Done
12 changes: 6 additions & 6 deletions Zend/tests/compare_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) != NULL
float(2.5) == bool(true)
float(2.5) != bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= object(stdClass)#1 (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= object(stdClass)#2 (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
!= object(test)#3 (0) {}
float(2.5) != array(0) {}
float(2.5) != int(-2147483648)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
== int(1)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= float(2.5)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
== int(1)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= float(2.5)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
== int(1)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
!= float(2.5)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_001_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) != NULL
float(2.5) == bool(true)
float(2.5) != bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
!= object(test)#%d (0) {}
float(2.5) != array(0) {}
float(2.5) != int(-9223372036854775808)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
== int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
== int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
!= float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
== int(1)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
!= float(2.5)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) > NULL
float(2.5) <= bool(true)
float(2.5) > bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
> object(stdClass)#1 (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
> object(stdClass)#2 (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
> object(test)#3 (0) {}
float(2.5) <= array(0) {}
float(2.5) > int(-2147483648)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
<= int(1)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
<= float(2.5)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
<= int(1)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
<= float(2.5)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
<= int(1)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
<= float(2.5)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_003_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) > NULL
float(2.5) <= bool(true)
float(2.5) > bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
> object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
> object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
> object(test)#%d (0) {}
float(2.5) <= array(0) {}
float(2.5) > int(-9223372036854775808)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
<= int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
<= float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
<= int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
<= float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
<= int(1)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
<= float(2.5)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_004.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) >= NULL
float(2.5) >= bool(true)
float(2.5) >= bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#1 (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#2 (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
>= object(test)#3 (0) {}
float(2.5) < array(0) {}
float(2.5) >= int(-2147483648)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
>= int(1)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
< float(2.5)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_004_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) >= NULL
float(2.5) >= bool(true)
float(2.5) >= bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
>= object(test)#%d (0) {}
float(2.5) < array(0) {}
float(2.5) >= int(-9223372036854775808)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
>= int(1)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
< float(2.5)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) >= NULL
float(2.5) >= bool(true)
float(2.5) >= bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#1 (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#2 (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
>= object(test)#3 (0) {}
float(2.5) < array(0) {}
float(2.5) >= int(-2147483648)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#1 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#2 (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
>= int(1)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
< float(2.5)
object(test)#3 (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
12 changes: 6 additions & 6 deletions Zend/tests/compare_005_64bit.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@ float(2.5) >= NULL
float(2.5) >= bool(true)
float(2.5) >= bool(false)
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
>= object(stdClass)#%d (0) {}
float(2.5)
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
>= object(test)#%d (0) {}
float(2.5) < array(0) {}
float(2.5) >= int(-9223372036854775808)
Expand Down Expand Up @@ -260,7 +260,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -285,7 +285,7 @@ object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
>= int(1)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to double in %s on line %d
Notice: Object of class stdClass could not be converted to float in %s on line %d
< float(2.5)
object(stdClass)#%d (0) {}
Notice: Object of class stdClass could not be converted to int in %s on line %d
Expand All @@ -310,7 +310,7 @@ object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
>= int(1)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to double in %s on line %d
Notice: Object of class test could not be converted to float in %s on line %d
< float(2.5)
object(test)#%d (0) {}
Notice: Object of class test could not be converted to int in %s on line %d
Expand Down
Loading