Redefine PDOException::$code with correct type #7839
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Dec 29, 2021
There was a problem hiding this comment.
Thank you! I don't see a BC break, so this looks good to me. Or is there an issue to merge that into PHP-8.1, @krakjoe, @patrickallaert, @ramsey?
|
There should't be a BC break, this change is only useful for documentation purposes. |
cmb69
approved these changes
Jan 1, 2022
FWIW: There was a BC break there. The property previously could be accessed from the outside, while it no longer can. |
Oh! Do we need to revert? |
Not for us. Our software is not officially compatible with PHP 8.1 yet and we already fixed the break on our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the
PDOExceptionclass synopsis page can automatically be generated in the manual.