Add ReflectionFunction::isAnonymous() #8499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
reviewed
May 5, 2022
nicolas-grekas
force-pushed
the
anonymous-closure
branch
from
2f6c425
to
74ce601
Compare
bwoebi
reviewed
May 5, 2022
dktapps
reviewed
May 5, 2022
TimWolla
reviewed
May 5, 2022
nicolas-grekas
force-pushed
the
anonymous-closure
branch
2 times, most recently
from
d2f6161
to
17dfc05
Compare
|
PR should be ready. Failures are unrelated to me. |
twose
reviewed
May 6, 2022
nicolas-grekas
force-pushed
the
anonymous-closure
branch
from
17dfc05
to
c531e5d
Compare
nikic
approved these changes
May 7, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed at https://externals.io/message/116282
This would be very much appreciated instead of doing
str_contains((new ReflectionFunction($f))->name, '{closure}').In Symfony, we use this check in many places to display user-friendly names for closures.