Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid signed integer overflow in php_random_range() #9066

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

zeriyoshi
Copy link
Contributor

re-fixed: #9060

@iluuu1994 @guilliamxavier
Thanks for the advice!

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zeriyoshi!

@TimWolla TimWolla self-requested a review July 20, 2022 15:34
@TimWolla TimWolla changed the title [random] fix undefined behaviour [random] fix signed integer overflow Jul 21, 2022
@TimWolla TimWolla changed the title [random] fix signed integer overflow Avoid signed integer overflow in php_random_range() Jul 21, 2022
@TimWolla
Copy link
Member

@zeriyoshi Please add a NEWS entry, then you can "Squash and merge" yourself 😃

Suggestion:

. Fixed bug GH-9066 (signed integer overflow). (zeriyoshi)

@zeriyoshi zeriyoshi merged commit 133b9b0 into php:master Jul 22, 2022
@zeriyoshi
Copy link
Contributor Author

@TimWolla
Thanks for the advice! I'm sure I'll gradually get used to it. :D

@zeriyoshi zeriyoshi deleted the upstream/random_ubsan branch July 22, 2022 06:18
@TimWolla
Copy link
Member

@zeriyoshi You accidentally added the NEWS entry to Beta 1. I've moved it to the correct position: c5f9b2f

@zeriyoshi
Copy link
Contributor Author

@zeriyoshi You accidentally added the NEWS entry to Beta 1. I've moved it to the correct position: c5f9b2f

Oh... Thanks!
I will pay attention in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants