Add IntlChar class to intl extension #961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes ICU's uchar functionality as a set of static methods
ICU version numbers go: 1.0 .. 4.8, then 49... Modify ifdef checks to account for that.
I can't believe it's finally gone... They should have sent a poet.
sgolemon
added a commit
to facebook/hhvm
that referenced
this pull request
Jan 16, 2015
Summary: Expose the functionality from http://icu-project.org/apiref/icu4c/uchar_8h.html in a way that is consistent with existing Intl APIs. Corresponding PHP7 PR: php/php-src#961 {sync, type="parent", child="external", childrevid="30573", childdiffid="164931", parentdiffid="6176331"} Reviewed By: @jwatzman Differential Revision: D1751393 Signature: t1:1751393:1421441790:98c3e5adeaf8e7f119db9e3a35f1cae155582291
|
Shouldn't it be closed now? |
|
I think this was already merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes ICU's uchar functionality as a set of static methods