Add option to run all tests with active observers #9850
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bugs only happen when observers are registered. This change makes it possible to register observers from the zend_test extension in all tests. The observers don’t really do anything, but just by being registered some bugs in the observer implementation can be caught. The full test suite can be run with observers by executing `TEST_PHP_ARGS='--with-test-observers' make test`.
iluuu1994
reviewed
Oct 30, 2022
|
Added in #13869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bugs only happen when observers are registered. This change makes it possible to register observers from the zend_test extension in all tests. The observers don’t really do anything, but just by being registered some bugs in the observer implementation can be caught.
The full test suite can be run with observers by executing
TEST_PHP_ARGS='--with-test-observers' make test.Right now some tests fail because of the issue fixed in #9849. I actually found that bug by running all tests with this new flag.