Skip to content

Link to doc.php.net and /my.php #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Link to doc.php.net and /my.php #1038

merged 2 commits into from
Jul 29, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Jul 26, 2024

Provide easier on-ramps!

Note that https://doc.php.net doesn't actually work quite yet (it's http-only), working with the systems team to get that fixed.

Provide easier on-ramps!
Copy link
Contributor

github-actions bot commented Jul 26, 2024

🚀 Commit 45d3ec3 Deployed on https://web-php-pr-1038.preview.thephp.foundation

docs.php Outdated
parts might be outdated. The translation teams are open to
contributions.
parts might be outdated. The translation teams are
<a href="https://doc.php.net/">open to contributions</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributions should not need to be directed to doc.php.net?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea here is to build out more information on doc.php.net about how to contribute (both to translations and the English version) but I think all we need on this page is a pointer over there so people can actually find it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After php/web-doc#49 merge, this could be a good starting point.

But I guess this PR should be delayed until https is working, or merge it now with http, and do another commit after configuring the certificate..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there isn't really an issue with it not being HTTPS, it is just a static website.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've changed it to just http: because doc.php.net is on a decrepit host for now and I'd rather not wait for that to be addressed.

Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined saundefined merged commit 0a5445c into php:master Jul 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants