-
Notifications
You must be signed in to change notification settings - Fork 562
Link to doc.php.net and /my.php #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Provide easier on-ramps!
🚀 Commit 45d3ec3 Deployed on https://web-php-pr-1038.preview.thephp.foundation |
docs.php
Outdated
parts might be outdated. The translation teams are open to | ||
contributions. | ||
parts might be outdated. The translation teams are | ||
<a href="https://doc.php.net/">open to contributions</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributions should not need to be directed to doc.php.net?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea here is to build out more information on doc.php.net about how to contribute (both to translations and the English version) but I think all we need on this page is a pointer over there so people can actually find it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After php/web-doc#49 merge, this could be a good starting point.
But I guess this PR should be delayed until https is working, or merge it now with http, and do another commit after configuring the certificate..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there isn't really an issue with it not being HTTPS, it is just a static website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've changed it to just http: because doc.php.net is on a decrepit host for now and I'd rather not wait for that to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Provide easier on-ramps!
Note that https://doc.php.net doesn't actually work quite yet (it's http-only), working with the systems team to get that fixed.