Adds a prepend link to the conf-list #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way it's easier to show people how to add a conference to the list.
|
@bjori — This looks like a great addition to me. Any objections? |
| @@ -26,7 +26,9 @@ | |||
| } | |||
| } | |||
| } | |||
| $panels = ""; | |||
| $panels = '<p class="prepend"><a href="https://wiki.php.net/conferences">Want to see your conference appear here?</a></p>'; | |||
There was a problem hiding this comment.
I don't think the "prepend" class does anything, did you mean "panel"?
There was a problem hiding this comment.
No, I actually meant "prepend". Currently the "panel"-class only sets the bottom-margin. My idea was to have a different class to allow a different styling of the prepend link as it's not a conference we're linking to there. But currently there's no styling added.
There was a problem hiding this comment.
That seems pointless, but it's a minor thing so... do what you want.
|
Merged. Hopefully the wiki page will be useful. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way it's easier to show people how to add a conference to the list.
For that I created a page in the wiki that the added link links to...